[PATCH] D42559: [CodeView] Speed up type merging by about 20%

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/lib/DebugInfo/CodeView/TypeStreamMerger.cpp:393
+      (Ref.Kind == TiRefKind::IndexRef) ? remapItemIndex(TI)
+                                        : remapTypeIndex(TI);
     }
----------------
zturner wrote:
> rnk wrote:
> > Looks like we lost error handling here.
> It turns out nothing actually depended on or used the error handling.  It seems like if we decide we need it in the future, we could just go back and re-add it.  For now, I was just trying to make the code as fast as possible.  If you think we should put it back though, I can.  The current behavior is actually the same as the original behavior though.
No, we were returning an empty record in the case where remapping failed. I mean, I'm sure we don't have tests for this case, but it would be nice to keep this NFC.


https://reviews.llvm.org/D42559