[PATCH] D42559: [CodeView] Speed up type merging by about 20%

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/lib/DebugInfo/CodeView/TypeStreamMerger.cpp:393
+      (Ref.Kind == TiRefKind::IndexRef) ? remapItemIndex(TI)
+                                        : remapTypeIndex(TI);
     }
----------------
rnk wrote:
> Looks like we lost error handling here.
It turns out nothing actually depended on or used the error handling.  It seems like if we decide we need it in the future, we could just go back and re-add it.  For now, I was just trying to make the code as fast as possible.  If you think we should put it back though, I can.  The current behavior is actually the same as the original behavior though.


https://reviews.llvm.org/D42559