[PATCH] D42551: [Debug] Add dbg.value intrinsics for PHIs created during LCSSA.

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 25 11:53:11 PST 2018


vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

LGTM, this is great.



================
Comment at: lib/Transforms/Utils/Local.cpp:1349
+  assert(BB && "No BasicBlock to clone dbg.value(s) from.");
+  if (!BB || InsertedPHIs.size() == 0)
+    return;
----------------
No need to check !BB defensively since we're asserting it.


https://reviews.llvm.org/D42551





More information about the llvm-commits mailing list