[PATCH] D41832: LLParser: do not verify LLVM module

[Davide Italiano via llvm-commits]

On Thu, Jan 25, 2018 at 11:34 AM, Adrian Prantl via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:
> aprantl added a comment.
>
> Thanks for checking!
>
> Based on this, we could either
>
> - make it the responsibility of the Caller of LLParser to run the Verifier and update those tools to run the Verifier.
> - or pass the override datalayout into LLParser so it can inject it before running the Verifier.
>
> I personally don't like the idea of relaxing the Verifier / making it verify something that is not what is being fed into the later stages. (Feel free to try and convince me otherwise though :-)
>

Agree. We spent a lot of time making the verifier more robust over the years.
If people don't care they can pass `-disable-verify` themselves, but
upstream should always have this option enabled IMHO, as if things
fail the verifier, generally bad things happen in the backend.

--
Davide