[PATCH] D42550: Put the header in the first PT_LOAD even if that PT_LOAD has a LMAExpr

[Rafael Avila de Espindola via llvm-commits]

Ed Maste via Phabricator <reviews at reviews.llvm.org> writes:

> emaste added inline comments.
>
>
> ================
> Comment at: test/ELF/linkerscript/merge-header-load.s:10-11
> +
> +# Test that we put the header in the first PT_LOAD. We used to create a PT_LOAD
> +# just for it and it would have a different virtual to physical address delta.
> +
> ----------------
> This is true only for the case where we set LMA (right?)
>
> In normal use w/o a linker script (or without setting LMA) the PT_PHDR is just included in the first PT_LOAD.

Yes, that was already true. In the absence of LMA the header was already
in the first PT_LOAD. Now we try to put it in the first PT_LOAD even if
we find an LMA.

Cheers,
Rafael