[PATCH] D42496: [CMake] Fix Bug Report URL

Colden Cullen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 25 11:19:46 PST 2018


colden added a comment.

In https://reviews.llvm.org/D42496#988265, @smeenai wrote:

> In https://reviews.llvm.org/D42496#986897, @colden wrote:
>
> > In https://reviews.llvm.org/D42496#986872, @smeenai wrote:
> >
> > > For future reference, you should upload diffs with more context (`-U9999`, or just use arcanist). This is trivial so it doesn't matter that much. It's also a good idea to add some reviewers explicitly, otherwise it's easy for things to slip through on the mailing list.
> >
> >
> > I did use arcanist, is there a special config option I have to set or something? I'm on Windows too, so maybe that's it? I'll dig around the internet to see if I can fix it for next time.
>
>
> `arc diff` should submit a diff with full context by default, but `arc` in general isn't entirely sane on Windows, so it wouldn't surprise me if it's doing something silly.


Yup, found it: https://secure.phabricator.com/T2465

Looks like there's a good workaroud in there, I'll try that in the future.

Thanks for submitting!


Repository:
  rL LLVM

https://reviews.llvm.org/D42496





More information about the llvm-commits mailing list