[PATCH] D41832: LLParser: do not verify LLVM module
Yaxun Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 25 10:41:17 PST 2018
yaxunl added a comment.
In https://reviews.llvm.org/D41832#988209, @aprantl wrote:
> Wouldn't it be better to move the `M->setDataLayout(ClDataLayout);` to before we run the Verifier? It seems like we should verify the module in the state that it will be eventually consumed.
Doing that solely is not enough for fixing the issue, since LLParser already calls Verifier before that by itself. Unless we provide LLParser a correct datalayout to override the datalayout from the IR, the verification inside the LLParser itself will still fail.
https://reviews.llvm.org/D41832
More information about the llvm-commits
mailing list