[PATCH] D42544: [X86][AVX512] Add combining support for X86ISD::VTRUNCS

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:34336
+        ISD::isConstantSplatVector(V.getOperand(1).getNode(), C))
+      return C == Limit ? V.getOperand(0) : SDValue();
+    return SDValue();
----------------
Can C == Limit be folded into the 'if' and just return V.getOperand(0). The not taken path of the if will take care of returning SDValue()


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:34366
 
-static SDValue
-combineTruncateWithUSat(SDValue In, EVT VT, SDLoc &DL, SelectionDAG &DAG,
-                        const X86Subtarget &Subtarget) {
+static SDValue combineTruncateWithSat(SDValue In, EVT VT, SDLoc &DL,
+                                      SelectionDAG &DAG,
----------------
Should this be a const SDLoc&   That's what most places use though there are a few non-const.


Repository:
  rL LLVM

https://reviews.llvm.org/D42544