[PATCH] D42542: Improve LMARegion handling

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

Looks good to me. Minor cosmetic comments/suggestions below.



================
Comment at: test/ELF/linkerscript/at3.s:17
+
+
+# CHECK: .foo1             PROGBITS        0000000000001000 001000
----------------
Excessive empty line.


================
Comment at: test/ELF/linkerscript/at3.s:25
+
+# CHECK: LOAD  0x001000 0x0000000000001000 0x0000000000006000
+# CHECK: LOAD  0x002000 0x0000000000002000 0x0000000000006008
----------------
I would add header:
```
Type           Offset   VirtAddr           PhysAddr
```
To make it clear where is Offset and VirtAddr and where is PhysAddr.


================
Comment at: test/ELF/linkerscript/at3.s:27
+# CHECK: LOAD  0x002000 0x0000000000002000 0x0000000000006008
+# CHECK: LOAD  0x003000 0x0000000000003000 0x0000000000006011
+
----------------
Looks you want to use CHECK-NEXT here ?


https://reviews.llvm.org/D42542