[PATCH] D38315: [ARM] Armv8.2-A FP16 code generation (part 1/2)

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMISelDAGToDAG.cpp:935
 
+bool ARMDAGToDAGISel::SelectAddrMode5FP16(SDValue N,
+                                          SDValue &Base, SDValue &Offset) {
----------------
Please refactor this with the above function. 


================
Comment at: lib/Target/ARM/ARMInstrVFP.td:712
 def VCVTBDH : ADuI<0b11101, 0b11, 0b0011, 0b01, 0,
+                   //(outs HPR:$Sd), (ins DPR:$Dm),
                    (outs SPR:$Sd), (ins DPR:$Dm),
----------------
olista01 wrote:
> Commented-out code
Lines to remove.


https://reviews.llvm.org/D38315