[PATCH] D40337: Support the setjmp(3) family of functions in TSan/NetBSD

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 25 03:09:53 PST 2018


krytarowski added inline comments.


================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:600
 
+#if !SANITIEZER_NETBSD
 extern "C" SANITIZER_INTERFACE_ATTRIBUTE
----------------
krytarowski wrote:
> vlad.tsyrklevich wrote:
> > This is misspelled here and twice below as well meaning it's never actually compiled. Is it actually necessary?
> Ah, good catch!
> 
> It's actually meaning that it's compiled always, also on NetBSD. I will try to disable it and check if there are regressions, if not I will commit a fix.
Fix has been committed.

http://llvm.org/viewvc/llvm-project?rev=323413&view=rev


Repository:
  rL LLVM

https://reviews.llvm.org/D40337





More information about the llvm-commits mailing list