[PATCH] D42390: msan: Pass --disable-new-dtags for tests

Thu Jan 25 02:56:20 PST 2018

hintonda added a comment.

In https://reviews.llvm.org/D42390#987558, @Hahnfeld wrote:

> In https://reviews.llvm.org/D42390#987554, @hintonda wrote:
>
> > I think unsetting LD_LIBRARY_PATH in the tests sounds reasonable -- many tests already do that.  
> >  However, I'm still unclear why doing this in compiler-rt/test/msan/Unit/ didn't work.  Can't you just unset LD_LIBRARY_PATH for those tests (not all tests and not globally, just add a lit.cfg file that does in that directory)?
>
>
> Which tests do that? AFAICS the asan tests you have been referring to add something to `LD_LIBRARY_PATH`...

Perhaps I should have said manipulate/set, etc.  The point is that is not unreasonable to change it.

However, I would again suggest you get away from relying on magic environment variables.  As far as I can tell, you are the only one having this issue.

Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D42390