[PATCH] D42390: msan: Pass --disable-new-dtags for tests

[Don Hinton via Phabricator via llvm-commits]

hintonda added a comment.

In https://reviews.llvm.org/D42390#987548, @Hahnfeld wrote:

> In https://reviews.llvm.org/D42390#987540, @hintonda wrote:
>
> > I'll let @eugenis speak for himself, but in general LD_LIBRARY_PATH is not a good idea.  A quick google search will provide a bunch of links to blogs and articles that make a much stronger case than I can.
>
>
> Okay, rethinking about this, we probably can't get rid of it in our environment because we use the modules system (http://modules.sourceforge.net/) which heavily relies on modifying environment variables.
>
> In general, would patches be acceptable (maybe in a different form) that solves this kind "problem"?


I think unsetting LD_LIBRARY_PATH in the tests sounds reasonable -- many tests already do that.  
However, I'm still unclear why doing this in compiler-rt/test/msan/Unit/ didn't work.  Can't you just unset LD_LIBRARY_PATH for those tests (not all tests and not globally, just add a lit.cfg file that does in that directory)?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D42390