[PATCH] D42390: msan: Pass --disable-new-dtags for tests

[Don Hinton via Phabricator via llvm-commits]

hintonda requested changes to this revision.
hintonda added a comment.
This revision now requires changes to proceed.

In https://reviews.llvm.org/D42390#987530, @Hahnfeld wrote:

> In https://reviews.llvm.org/D42390#987526, @hintonda wrote:
>
> > Well, perhaps the second, i.e., s/evil/last resort/:
> >
> > > In https://reviews.llvm.org/D42390#987043, @eugenis wrote:
> > >  Right. That's why LD_LIBRARY_PATH is evil, as are environment variables in general.
> > >  IMHO the right way is to set DT_RUNPATH for each executable that wants non-standard libraries. That includes your host compiler.
>
>
> I understood this to be related to setting environment variables in the test. As the name suggest they are meant for the environment.


I'll let @eugenis speak for himself, but in general LD_LIBRARY_PATH is not a good idea.  A quick google search will provide a bunch of links to blogs and articles that make a much stronger case than I can.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D42390