[PATCH] D42390: msan: Pass --disable-new-dtags for tests

Don Hinton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 25 01:49:08 PST 2018


hintonda added a comment.



In https://reviews.llvm.org/D42390#987495, @Hahnfeld wrote:

> In https://reviews.llvm.org/D42390#987486, @hintonda wrote:
>
> > Since it's a problem with your particular environment, I think you should fix that instead.
>
>
> I strongly disagree: Environment variables are used like that in the wild. And the same thing will happen when `libc++` is installed to `/usr/lib` one day in the future.


Pretty sure /usr/lib gets searched last, i.e., DT_RUNPATH always wins unless LD_LIBRARY_PATH is set.  As a general rule, only set LD_LIBRARY_PATH as a last resort, and if you have a special case, use a wrapper script.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D42390





More information about the llvm-commits mailing list