[PATCH] D42501: [dsymutil] Generate Apple accelerator tables

[Pavel Labath via Phabricator via llvm-commits]

labath added inline comments.


================
Comment at: tools/dsymutil/DwarfLinker.cpp:10-11
 
+#include "../../lib/CodeGen/AsmPrinter/DwarfAccelTable.h"
+
 #include "BinaryHolder.h"
----------------
This seems a bit dodgy. Shouldn't the header be moved to the include folder if you want to access it outside codegen ?


================
Comment at: tools/dsymutil/DwarfLinker.cpp:631
+/// Add a namespace accelerator entry for \p Die with \p Name
+/// which is stored in the string table at \p Offset.
+void CompileUnit::addNamespaceAccelerator(const DIE *Die,
----------------
There's no `Offset` in this function


Repository:
  rL LLVM

https://reviews.llvm.org/D42501