[PATCH] D42486: [ELF][MIPS] Ignore incorrect version definition index for _gp_disp symbol

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/InputFiles.cpp:860
+    if (Config->EMachine == EM_MIPS) {
+      // MIPS BFD linker puts _gp_disp symbol into DSO files and incorrectly
+      // assigns VER_NDX_LOCAL to this section global symbol.
----------------
I suggest to add "FIXME: " at the begining of comment,
saying that this hack can be removed once fixed in BFD and settle for a while.
It's consistent with other hacks/workarounds we have in code.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42486