[PATCH] D42520: Implement __attribute__((import_module("foo")))

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added a comment.

Renaming the default module to `__linker_resolve` seems fine.

However, https://reviews.llvm.org/D42495 currently in progress involves changing the way symbols are read from a Wasm object file. There's now going to be an explicit symbol table, so the linker won't resolve all imports, but only imports which correspond to symbols. I guess we could have WasmObjectWriter skip any imports that aren't in the `__linker_resolve` module, and not create symbols for them; and the linker could merge together imports from the object files that come from other modules...

Is there any current use-case for allowing the module to be customised?


Repository:
  rL LLVM

https://reviews.llvm.org/D42520