[PATCH] D42512: [X86] When using Win64 ABI, exit with error if SSE is disabled for varargs

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 24 17:50:29 PST 2018


aemerson added a comment.

Right, it's not clear to me how we'd avoid crashing later on since in this case it happens in a later pass, not in isel. If report_fatal_error does indeed always triggers crash diagnostics in clang then this is no better than assertion failures. Perhaps emitting the diagnostic first with errorUnsupported might be better than nothing.


Repository:
  rL LLVM

https://reviews.llvm.org/D42512





More information about the llvm-commits mailing list