[PATCH] D41674: [Support] CommandLine API -- Allow creating custom parsers for fundamental types

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 24 17:18:50 PST 2018


Does this (attached patch) make sense to avoid making printOptionDiff
virtual? (a bit of SFINAE)

On Mon, Jan 15, 2018 at 9:25 AM serge via Phabricator <
reviews at reviews.llvm.org> wrote:

> serge-sans-paille added a comment.
>
> @ckristo sorry for the delay, I just realized that you missed to update
> the cl documentation, which is the actual point of this patch :-) Otherwise
> LGTM
>
>
> https://reviews.llvm.org/D41674
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180125/79ec7b2a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: commandline.diff
Type: text/x-patch
Size: 7391 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180125/79ec7b2a/attachment.bin>


More information about the llvm-commits mailing list