[PATCH] D41832: LLParser: do not verify LLVM module

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/IR/Verifier.cpp:214-216
+    // If TreatBrokenDebugInfoAsError is set, ignore non-DebugInfo errors.
+    if (!TreatBrokenDebugInfoAsError)
+      return;
----------------
yaxunl wrote:
> arsenm wrote:
> > This seems to just be stopping all error messages?
> No. This will only stop checking of non-debug info and will not stop checking debug info. Since checking of debug info does not use this function but uses DebugInfoCheckFailed.
Can you please elaborate on this? I'm afraid I didn't understand your explanation.


================
Comment at: lib/IR/Verifier.cpp:3239
   Assert(PTy->getAddressSpace() == DL.getAllocaAddrSpace(),
-         "Allocation instruction pointer not in the stack address space!",
+         "Allocation instruction pointer not in the dataLayout alloca address space!",
          &AI);
----------------
Please move this change into a separate review, it looks like an orthogonal change and just makes this patch harder to understand.


https://reviews.llvm.org/D41832