[PATCH] D41373: [GISel][RFC]: GlobalISel Combiner prototype

[Amara Emerson via Phabricator via llvm-commits]

aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

LGTM with some minor comment fixes.



================
Comment at: include/llvm/CodeGen/GlobalISel/CombinerHelper.h:13
+/// Targets can pick individual opcode transformations from the helper or use
+/// tryCombine which invokes all transformations. All of the transformations return
+/// true if the MachineInstruction changed and false otherwise.
----------------
80 cols?


================
Comment at: include/llvm/CodeGen/GlobalISel/CombinerInfo.h:11
+/// Interface for Targets to specify which operations are combined how and when.
+/// //
+//===----------------------------------------------------------------------===//
----------------
Superfluous '//'.


================
Comment at: lib/CodeGen/GlobalISel/Combiner.cpp:11
+// This file constains common code to combine machine functions at generic
+// level. //
+//===----------------------------------------------------------------------===//
----------------
Same here.


================
Comment at: lib/CodeGen/GlobalISel/CombinerHelper.cpp:40
+bool CombinerHelper::tryCombine(MachineInstr &MI) {
+  // Right now just do the above.
+  return tryCombineCopy(MI);
----------------
I think we're better off without this comment.


https://reviews.llvm.org/D41373