[PATCH] D42450: [utils] Convert update_{llc_, }test_checks.py to Python 3

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 24 13:39:00 PST 2018


MatzeB added a comment.

>   I'd like to see llvm moving away from legacy python2.7

That needs discussion on llvm-dev to make sure everyone is on the same page, GettingStarted.rst is updated etc. Forcing just a single script to python3 is not a good idea.

FWIW I don't understand why we waste time making our script compatible to python2 and python3 at the same time, it just doubles testing efforts. I'd rather see us go all-in on python3 (or stay with python2 and don't bother). And I personally think we should go all-in for python3...

> so I must've done something to be able to run these scripts on my machine. :)

Well installing any homebrew or macports python (which is often a dependency for other packages) will give you a python2 with the proper symlinks in place. It's usually people maintaining CI infrastructured that are bothered by macOS (or linux) default installations.


Repository:
  rL LLVM

https://reviews.llvm.org/D42450





More information about the llvm-commits mailing list