[PATCH] D42302: AMDGPU: Allow a SGPR for the conditional KILL operand.

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

One minor nitpack, apart from that LGTM.



================
Comment at: lib/Target/AMDGPU/SIInsertSkips.cpp:263-265
+    if (!MI.getOperand(0).isReg()) {
+      llvm_unreachable("SI_KILL_F32_COND_IMM operand 0 should be a VGPR or a SGPR\n");
+    }
----------------
This could just be an assert. I'm also not entirely convinced that it's required. src0 is a VSrc_b32, same as for V_CMPX_, but I suppose it doesn't hurt.


Repository:
  rL LLVM

https://reviews.llvm.org/D42302