[PATCH] D42450: [utils] Convert update_{llc_, }test_checks.py to Python 3

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 24 09:13:50 PST 2018


spatel added a comment.

In https://reviews.llvm.org/D42450#985851, @MaskRay wrote:

> I intent to add something called update_clang_test_checks.py (.cc -> .ll or .cc -> .s) and find these scripts really should be combined..


I fully support automating clang test checks - see https://reviews.llvm.org/D17999 for some existing work in this direction.

I also support combining the opt and llc scripts, but I don't have the python skills to do it - https://reviews.llvm.org/rL305208 . My only experience with python is a couple of days on these scripts, so you can assume anything I've done is amateur at best.

For this reason, I'm also not qualified to review major improvements to the scripts, but I appreciate being cc'd here to know about the direction (and of course I use the scripts all the time).

re: macOS - I develop on macOS almost exclusively (I may even be the last one using Xcode to hack on LLVM!)...so I must've done something to be able to run these scripts on my machine. :)


Repository:
  rL LLVM

https://reviews.llvm.org/D42450





More information about the llvm-commits mailing list