[PATCH] D42471: [ARM] Fix lld crash introduced by r321154

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 24 09:10:25 PST 2018


peter.smith added a comment.

Thanks for adding the test. I've added a small suggestion in an inline comment.



================
Comment at: test/ELF/arm-exidx-discard.s:5
+// REQUIRES: arm
+
+.globl  __entrypoint
----------------
May I suggest adding a comment to explain what the test is for? Something like "// Check that the linker generated .ARM.exidx sentinel section is correctly removed. You then could use llvm-readobj to dump the Sections and use CHECK-NOT for .arm.exidx. That would make sure that we don't regress by crashing or by somehow keeping the linker generated sentinel. 


https://reviews.llvm.org/D42471





More information about the llvm-commits mailing list