[PATCH] D42222: [llvm-objcopy] Refactor llvm-objcopy to use reader and writer objects

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

One small inline comment. Otherwise, I'm happy with this as-is. Are you still planning on splitting it up? It'll make it somewhat easier, I hope to spot any problems, but if it's a lot of extra work, may no longer be worth it.



================
Comment at: test/tools/llvm-objcopy/binary-out-error.test:1
+# RUN: not llvm-objcopy -O binary %p/Inputs/alloc-symtab.o %t2 2>&1 >/dev/null | FileCheck %s --check-prefix=SYMTAB
+# SYMTAB: Cannot write symbol table '.symtab' out to binary
----------------
What's going on with the "/dev/null" here?


Repository:
  rL LLVM

https://reviews.llvm.org/D42222