[PATCH] D42417: [SCEV] Fix isLoopEntryGuardedByCond

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 23 22:26:42 PST 2018


sanjoy added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:9066
+  // Both LHS and RHS must be available at loop entry.
+  if (!isAvailableAtLoopEntry(LHS, L) || !isAvailableAtLoopEntry(RHS, L))
+    return false;
----------------
I think this should be an assert -- if a caller is passing in unavailable SCEVs then it probably has other bugs too which this change will hide.


https://reviews.llvm.org/D42417





More information about the llvm-commits mailing list