[PATCH] D42436: libcxx: Allow auto-linking to be disabled with a macro.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 23 17:38:28 PST 2018


pcc added a comment.

In https://reviews.llvm.org/D42436#985780, @compnerd wrote:

> I'm fine with the idea of this knob, I just would prefer a slightly different implementation.  Could you wrap the entire block in the `defined(_LIBCPP_NO_AUTO_LINK)` rather than adding the additional conditional?  I feel like it makes it easier to read.


Done.


https://reviews.llvm.org/D42436





More information about the llvm-commits mailing list