[PATCH] D42441: IRGen: Emit an inline implementation of __builtin_wmemcmp on MSVCRT platforms.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc marked an inline comment as done.
pcc added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1771-1774
+    Value *DstCh =
+        Builder.CreateAlignedLoad(WCharTy, DstPhi, CharUnits::fromQuantity(2));
+    Value *SrcCh =
+        Builder.CreateAlignedLoad(WCharTy, SrcPhi, CharUnits::fromQuantity(2));
----------------
majnemer wrote:
> Should we be more explicit about where 2 comes from? Maybe `getTypeAlignInChars(WCharTy)`?
Sure, works for me.


https://reviews.llvm.org/D42441