[PATCH] D42369: Issue local statics in correct DWARF lexical scope

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 23 16:43:01 PST 2018


probinson added a comment.

Did you see David's emailed comment?



================
Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:347
   return Die;
 }
 
----------------
Looks like createAndAddDIE could become simply
`return Parent.addChild(createDIE(Tag, N));`
now or as an NFC follow-up, to reduce duplication.


https://reviews.llvm.org/D42369





More information about the llvm-commits mailing list