[PATCH] D42400: [PPC] Avoid incorrect fp-i128-fp lowering.

[Eric Christopher via Phabricator via llvm-commits]

echristo accepted this revision.
echristo added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/PowerPC/fp-int128-fp-combine.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -O0 -mtriple=powerpc64le-unknown-linux-gnu < %s | FileCheck %s
----------------
timshen wrote:
> jtony wrote:
> > Can we explicitly put CHECK-NOT for the `xscvdpsxds +
> > xscvsxdsp` instructions we were generating before in this test case to avoid regression? 
> > Other than that, the patch LGTM.
> IIRC update_llc_test_checks.py will remove old CHECKs and re-insert its own CHECKs.
> 
> I think with the current line-by-line CHECK-NEXTs, it effectively prevents xscvdpsxds and xscvsxdsp from creeping in.
It does. And you've got a comment as well so that if it breaks when updating people know what to look for.

With that said, I'm good with this as well. Let's let jtony also ack though since he did the main review.


https://reviews.llvm.org/D42400