[PATCH] D42095: [WebAssembly] Symbol changes #3: Cosmetic table, LLVM. NFC.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 23 12:09:21 PST 2018


sbc100 added a comment.

Can you update the description of this change?  I'm not sure all of it still applies.



================
Comment at: lib/MC/WasmObjectWriter.cpp:220
   DenseMap<const MCSymbolWasm *, uint32_t> SymbolIndices;
+  // Maps function symbol indices to the table element index space. Used
+  // for TABLE_INDEX relocation types (i.e. address taken functions).
----------------
Maps function index to table element index, no?  Only functions can exist in this map right?


Repository:
  rL LLVM

https://reviews.llvm.org/D42095





More information about the llvm-commits mailing list