[PATCH] D42433: [WebAssembly] Update wasm target triple now that its the default

Tue Jan 23 12:06:59 PST 2018

sunfish added a comment.

In https://reviews.llvm.org/D42433#985505, @sbc100 wrote:

> Maybe once we drop the ELF output comletely we can  remove this part?

Sure, that's probably harmless.

> Also, how do you feel about passing the -mtripple to llc vs embedding the triple in the bitcode text?  I see both done and I'd like to be consistent.

Most of the codegen tests embed the triple in the code, because I have found it convenient to run things like "llc test/CodeGen/WebAssembly/i32.ll" to see what the code looks like. That said, this doesn't always work, because some tests need to pass additional arguments, and some tests have multiple RUN lines to test multiple targets. So I'd be ok either way.

Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42433