[llvm] r323140 - asan: allow inline instrumentation for the kernel

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 23 11:44:10 PST 2018


On Tue, Jan 23, 2018 at 8:22 PM, Vedant Kumar <vsk at apple.com> wrote:
> Could you please add a test?

Please comment on the review thread, because author is not here.

>> On Jan 22, 2018, at 11:07 AM, Dmitry Vyukov via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: dvyukov
>> Date: Mon Jan 22 11:07:11 2018
>> New Revision: 323140
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=323140&view=rev
>> Log:
>> asan: allow inline instrumentation for the kernel
>>
>> Currently ASan instrumentation pass forces callback
>> instrumentation when applied to the kernel.
>> This patch changes the current behavior to allow
>> using inline instrumentation in this case.
>>
>> Authored by andreyknvl. Reviewed in:
>> https://reviews.llvm.org/D42384
>>
>>
>> Modified:
>>    llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
>>
>> Modified: llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp?rev=323140&r1=323139&r2=323140&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp (original)
>> +++ llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp Mon Jan 22 11:07:11 2018
>> @@ -2494,7 +2494,6 @@ bool AddressSanitizer::runOnFunction(Fun
>>   }
>>
>>   bool UseCalls =
>> -      CompileKernel ||
>>       (ClInstrumentationWithCallsThreshold >= 0 &&
>>        ToInstrument.size() > (unsigned)ClInstrumentationWithCallsThreshold);
>>   const DataLayout &DL = F.getParent()->getDataLayout();
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>


More information about the llvm-commits mailing list