[PATCH] D42433: [WebAssembly] Update wasm target triple now that its the default

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 23 11:22:15 PST 2018


sbc100 added a comment.

Exactly.

BTW, do you think we should also drop one or both of the "-unknown"?   I'm not sure about there.. there seems to be of precedence for "foo-unknown" in the existing tests:

  sbc.sbc1 (~/dev/wasm/llvm) $ git grep "triple=[^\-]* " test/    | wc -l
  603
  sbc.sbc1 (~/dev/wasm/llvm) $ git grep "triple=[^\-]*-unknown " test/   | wc -l
  537
  sbc.sbc1 (~/dev/wasm/llvm) $ git grep "triple=[^\-]*-unknown-unknown " test/   | wc -l
  2166

Seems like the "-unknown-unknown" is normally explicit, and that single element triples are comparatively rare.. I'm not sure.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42433





More information about the llvm-commits mailing list