[PATCH] D42375: Add --print-icf flag

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 23 11:02:02 PST 2018


Owen Reynolds <gbreynoo at gmail.com> writes:

> Hi Rafael,
>
> I'd like some clarification. Currently either "log()" or "message()" will
> be called with the same calculated message, so moving this to inside
> "print()" would not change things.

The difference is that at least log takes a Twine, which can avoid
memory allocation that std::string cannot.

Ideally print would return early if we don't have print-icf-sections or
verbose. Since you are changing the area, I suggested doing that.

Cheers,
Rafael


More information about the llvm-commits mailing list