[PATCH] D42406: Utils: Fix DomTree update for entry block
Brian Rzycki via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 23 10:54:42 PST 2018
brzycki accepted this revision.
brzycki added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D42406#985221, @arsenm wrote:
> In https://reviews.llvm.org/D42406#985160, @brzycki wrote:
>
> > I too am curious how this managed to not be found for several years. @arsenm how did you discover this?
>
>
> I'm working on a replacement for StructurizeCFG which needs to insert a block before certain blocks. Sometimes that ends up picking the entry block
Thanks @arsenm for the explanation. I was curious to know if you found this with a specific .c/.cpp file or if it was from changing the middle-end. The latter makes a lot more sense to discover a latent bug like this.
LGTM.
https://reviews.llvm.org/D42406
More information about the llvm-commits
mailing list