[PATCH] D42334: [NFC] Refactor Apple Accelerator Tables

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 23 09:48:28 PST 2018


JDevlieghere added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfAccelTable.h:324
+  DA.Name = Name;
+  DA.Values.push_back(new (Allocator) DataT(D));
+}
----------------
aprantl wrote:
> This is just me being curious: Would it make sense to have users pass the `new (Allocator) DataT(D)` and not make this a template at all?
Wouldn't you agree that exposing the allocator to the caller makes a horrible interface? 


https://reviews.llvm.org/D42334





More information about the llvm-commits mailing list