[PATCH] D42374: [RFC] Add IsFixed field to ISD::ArgFlagsTy

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 23 05:20:15 PST 2018


asb added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/FastISel.cpp:976
+  unsigned i = 0;
   for (auto &Arg : CLI.getArgs()) {
     Type *FinalType = Arg.Ty;
----------------
chenwj wrote:
> Would changing the range-based for loop to index-based one be more consistent?
Yes I think that would be better. I put this together quickly to get initial feedback on the overall direction. I'll move to an index-based loop in the next update. Thanks for taking a look!


Repository:
  rL LLVM

https://reviews.llvm.org/D42374





More information about the llvm-commits mailing list