[PATCH] D39196: [ARM] Remove pre-UAL FLDM/FSTM aliases

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 22 22:09:33 PST 2018


ikudrin added a comment.

Hi @rengolin

In https://reviews.llvm.org/D39196#904887, @rengolin wrote:

> I fear someone will eventually cry foul that we "broke their code".


You were right. I afraid that this change breaks building some Android code. See https://android.googlesource.com/platform/frameworks/av, and, for example, the `android-8.1.0_r9` tag, `media/libstagefright/codecs/aacenc/src/asm/ARMV7/*.S`. These files use `fstmfdd` and `fldmfdd` and are failed to compile now. They are already removed from the master branch (merge commit 69d60c1372, 17-Oct-2017), however, I believe that we have to be able to compile the existing versions.


Repository:
  rL LLVM

https://reviews.llvm.org/D39196





More information about the llvm-commits mailing list