[llvm] r323161 - Revert r322595: Specify inline for isWhitespace in CommandLine.cpp

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 22 15:27:51 PST 2018


Author: ruiu
Date: Mon Jan 22 15:27:50 2018
New Revision: 323161

URL: http://llvm.org/viewvc/llvm-project?rev=323161&view=rev
Log:
Revert r322595: Specify inline for isWhitespace in CommandLine.cpp

The original change was made based on a misunderstanding that
-DCMAKE_BUILD_TYPE=RelWithDebugInfo would produce the same executable
as -DCMAKE_BUILD_TYPE=Release modulo debug info. Turned out that's not
true -- it at least disables some optimizations such as function inlining.

Modified:
    llvm/trunk/lib/Support/CommandLine.cpp

Modified: llvm/trunk/lib/Support/CommandLine.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/CommandLine.cpp?rev=323161&r1=323160&r2=323161&view=diff
==============================================================================
--- llvm/trunk/lib/Support/CommandLine.cpp (original)
+++ llvm/trunk/lib/Support/CommandLine.cpp Mon Jan 22 15:27:50 2018
@@ -688,7 +688,7 @@ static bool EatsUnboundedNumberOfValues(
          O->getNumOccurrencesFlag() == cl::OneOrMore;
 }
 
-static inline bool isWhitespace(char C) {
+static bool isWhitespace(char C) {
   return C == ' ' || C == '\t' || C == '\r' || C == '\n';
 }
 




More information about the llvm-commits mailing list