[PATCH] D41876: Add a utility to reduce GlobalISel tests

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 22 14:25:28 PST 2018


qcolombet added a comment.

In https://reviews.llvm.org/D41876#972584, @volkan wrote:

> In https://reviews.llvm.org/D41876#972547, @bogner wrote:
>
> > In https://reviews.llvm.org/D41876#971616, @volkan wrote:
> >
> > > In https://reviews.llvm.org/D41876#971552, @qcolombet wrote:
> > >
> > > > Could this be extended to reduce any isel related bug?
> > >
> > >
> > > Yes, it can be extended to reduce the other ISel problems by adding a regex and the specific arguments for llc.
> >
> >
> > I'm guessing the answer is no since you'd have to update the regex as well, but would it make sense to allow llc arguments to be passed through from the command line or something like that?
>
>
> I thought we could have a regex, argument list pair for each error type.


I didn't mean to have my comment hold on this patch. I think it is already an improvement and should push it to take advantage of it now. We can improve things further later as we see fit.


https://reviews.llvm.org/D41876





More information about the llvm-commits mailing list