[PATCH] D42390: msan: Pass --disable-new-dtags for tests

[Jonas Hahnfeld via Phabricator via llvm-commits]

Hahnfeld created this revision.
Hahnfeld added reviewers: phosek, vitalybuka, ruiu, kcc.
Herald added subscribers: Sanitizers, llvm-commits, mgorny.

We really want to have DT_RPATH instead of DT_RUNPATH: When
searching for dynamic libraries, DT_RPATH is searched before
LD_LIBRARY_PATH while DT_RUNPATH is looked afterwards. So if
there is a libc++ in LD_LIBRARY_PATH, the tests will fail
because the found library is not instrumented.

This currently happens with GNU gold and lld while GNU ld
still defaults to "old dtags". However, GNU ld can also be
configured differently since binutils 2.29 as of last year.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D42390

Files:
  lib/msan/tests/CMakeLists.txt


Index: lib/msan/tests/CMakeLists.txt
===================================================================
--- lib/msan/tests/CMakeLists.txt
+++ lib/msan/tests/CMakeLists.txt
@@ -120,6 +120,7 @@
     DEPS ${MSAN_TEST_DEPS}
     LINK_FLAGS ${MSAN_UNITTEST_LINK_FLAGS}
                ${TARGET_LINK_FLAGS}
+               "-Wl,--disable-new-dtags"
                "-Wl,-rpath=${CMAKE_CURRENT_BINARY_DIR}"
                "-Wl,-rpath=${LIBCXX_PREFIX}/lib")
 endmacro()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42390.130940.patch
Type: text/x-patch
Size: 464 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180122/70ca0eed/attachment.bin>