[PATCH] D39967: Refactoring of MemoryWrite function
Tatyana Krasnukha via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 22 10:47:49 PST 2018
tatyana-krasnukha added a comment.
Herald added a subscriber: llvm-commits.
What about having 2 versions:
1. WriteMemory(..., bool force = false), that fails if there are breakpoints in the area. Let user decide what to do.
If force == true just call DoWriteMemory without checking on breakpoints. It is needed while writing on stack, for example (and to all sections beside .text ?).
All usages should be followed with if (status.Success()).
2. WriteMemorySavingBreakpoints for that cases where it is really needed. It will not return bytes_written, only status.
Repository:
rL LLVM
https://reviews.llvm.org/D39967
More information about the llvm-commits
mailing list