[PATCH] D41818: [AArch64][SVE] Asm: Predicate patterns

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, uses and test cases in https://reviews.llvm.org/D41819



================
Comment at: lib/Target/AArch64/InstPrinter/AArch64InstPrinter.cpp:1350
+  else
+    O << '#' << formatImm(Val);
+}
----------------
sdesmalen wrote:
> fhahn wrote:
> > IIUC this case happens if we want to print a pattern that is not in lookupSVEPREDPATByEncoding, right? Could we use an assert here, as I think this case should not happen if we do everything correctly?
> Correct, however we cannot assert here since this case needs to be supported. See for instance the tests in D41819 like `ptrue   p7.s, #15`. Immediate 15 does not have an associate pattern string and should be printed as immediate instead.
Right, thanks.


https://reviews.llvm.org/D41818