[PATCH] D36311: [ThinLTO] Add GraphTraits for FunctionSummaries

[Teresa Johnson via llvm-commits]

On Sat, Jan 20, 2018 at 2:37 PM, Easwaran Raman <eraman at google.com> wrote:

> I don't see D42311 as going in a different direction than this one. My
> patch extends GraphTraits to iterate over the outgoing edges of  node while
> this patch specializes CallGraphTraits for ModuleSummaryIndex.
>

Ok, I misunderstood based on the description there and your comments about
duplicating some of the summary info in D42212. Presumably then you can use
this patch to do the necessary SCC based propagation of relative
frequencies during the thin link then.


> On Fri, Jan 19, 2018 at 8:43 PM, Teresa Johnson via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> tejohnson added a comment.
>>
>> Sorry, I missed these being updated. Will take another pass through but
>> it looks like you have addressed my comments.
>>
>> Easwaran - can this be used to do the call graph walks you need for
>> synthetic counts propagation? If not we need to figure out why, because I
>> see you are going in a different direction in
>> https://reviews.llvm.org/D42311.
>>
>>
>> https://reviews.llvm.org/D36311
>>
>>
>>
>>
>


-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |  408-460-2413
<(408)%20460-2413>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180121/baed9676/attachment.html>