[PATCH] D41293: [DAG, X86] Improve Dependency analysis when doing multi-node Instruction Selection

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 20 10:00:33 PST 2018


RKSimon added a comment.

Apart from a very minor tweak, no more comments - someone who knows this code better should give it the once over if possible.



================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGNodes.h:817
+
+    auto NId = N->getNodeId();
+
----------------
Maybe better to use int instead of auto - the type isn't obvious? Same for MId below.


https://reviews.llvm.org/D41293





More information about the llvm-commits mailing list