[PATCH] D42100: Fix codegen of stores of vectors with non byte-sized elements.

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa closed this revision.
jonpa marked 3 inline comments as done.
jonpa added a comment.

Thanks for review!

Committed as trunk at 323042.



================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2017
+  // Scalarize if elements and the split halves are not byte-sized.
+  if (!MemoryVT.getScalarType().isByteSized() &&
+      (!LoMemVT.isByteSized() || !HiMemVT.isByteSized()))
----------------
efriedma wrote:
> I think the "MemoryVT.getScalarType().isByteSized()" check is redundant.  Not a big deal either way.
Yes, I think you are right :-) removed.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:3471
+  unsigned Stride = MemSclVT.getSizeInBits() / 8;
+  assert (Stride && "Zero stride!");
+
----------------
efriedma wrote:
> Extra space after assert.
removed


================
Comment at: test/CodeGen/SystemZ/vec-move-17.ll:65
 define void @f7(<2 x i64> %val, <2 x i1> *%ptr) {
-; No expected output, but must compile.
   %trunc = trunc <2 x i64> %val to <2 x i1>
----------------
craig.topper wrote:
> Why did this comment get deleted?
On Jan 16, I wrote: "(SystemZ/vec-move-17.ll was previously just supposed to compile, but now there should probably be some test as well once it actually compiles with patch)."

I have now added some CHECKs and left the comment deleted.



https://reviews.llvm.org/D42100