[PATCH] D42326: [COFF] don't replace import library if contents are unchanged
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 19 18:32:14 PST 2018
ruiu added inline comments.
================
Comment at: lld/COFF/Driver.cpp:540-541
+ };
+ auto LibName = getImportName(AsLib);
+ auto Path = getImplibPath();
+
----------------
Please write the real types instead of `auto`.
================
Comment at: lld/COFF/Driver.cpp:563
+
+ auto NewBuf = check(MemoryBuffer::getFile(TmpName));
+ if ((*OldBuf)->getBuffer() != NewBuf->getBuffer()) {
----------------
Ditto
https://reviews.llvm.org/D42326
More information about the llvm-commits
mailing list